refactor: vulnerability plugin contract to accept client.Object #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #894 +/- ##
==========================================
+ Coverage 65.58% 65.81% +0.22%
==========================================
Files 58 58
Lines 6512 6520 +8
==========================================
+ Hits 4271 4291 +20
+ Misses 1810 1797 -13
- Partials 431 432 +1
Continue to review full report at Codecov.
|
danielpacak
suggested changes
Jan 10, 2022
There was a problem hiding this comment.
Hey @deven0t Looks good. Just left a few remarks. Make sure that you don't change import statements that much.
deven0t
force-pushed
the
refactor-vuln-plugin-contract
branch
from
67f804a
to
907e9a6
Compare
deven0t
force-pushed
the
refactor-vuln-plugin-contract
branch
from
907e9a6
to
ca74570
Compare
…ad of podSpec This is needed for future development where we need more information of object which we are scanning.
deven0t
force-pushed
the
refactor-vuln-plugin-contract
branch
from
ca74570
to
9fde163
Compare
danielpacak
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for future development where we need more information on the object which we are scanning.