fix tf v1.1.0 init module sources #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ix-tf-v1.1.0-init-modules-source
liamg
approved these changes
Jan 4, 2022
|
Thanks for this, we should have a release out in roughly a week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue with the terraform v1.1.0+ module sources
by changing matching on module source to matching on module name with module key in the json metadata file.
module source is since tf 1.1.0 no longer always equal to the source in the metadata json file(.terraform\modules\modules.json) ,for instance terraform/hashicorp auto resolves to registry.terraform.com, googleapis.com to gcs etc..
see issue #1188