Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Trivy callout and migration guide added #2021

Merged
merged 7 commits into from May 4, 2023

Conversation

AnaisUrlichs
Copy link
Member

Related to the tasks in the following issue #2016

@AnaisUrlichs AnaisUrlichs changed the title callout added to index docs docs: Callout and migration guide added Mar 30, 2023
@AnaisUrlichs AnaisUrlichs changed the title docs: Callout and migration guide added docs: Trivy callout and migration guide added Mar 30, 2023
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Show resolved Hide resolved
docs/index.md Show resolved Hide resolved
tfsec-to-trivy-migration-guide.md Outdated Show resolved Hide resolved
tfsec-to-trivy-migration-guide.md Outdated Show resolved Hide resolved
tfsec-to-trivy-migration-guide.md Outdated Show resolved Hide resolved
tfsec-to-trivy-migration-guide.md Show resolved Hide resolved
@github-actions
Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 365 days.

@github-actions github-actions bot added the stale Stale issues will be closed within 7 days of this label being assigned label Apr 29, 2023
@AnaisUrlichs AnaisUrlichs added documentation and removed stale Stale issues will be closed within 7 days of this label being assigned labels Apr 30, 2023
Signed-off-by: AnaisUrlichs <urlichsanais@gmail.com>
@AnaisUrlichs
Copy link
Member Author

Hi @itaysk made some updates to the guide

Signed-off-by: AnaisUrlichs <urlichsanais@gmail.com>
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Show resolved Hide resolved
tfsec-to-trivy-migration-guide.md Show resolved Hide resolved
tfsec-to-trivy-migration-guide.md Outdated Show resolved Hide resolved
tfsec-to-trivy-migration-guide.md Outdated Show resolved Hide resolved
docs/index.md Show resolved Hide resolved
Signed-off-by: AnaisUrlichs <urlichsanais@gmail.com>
Signed-off-by: AnaisUrlichs <urlichsanais@gmail.com>
@AnaisUrlichs AnaisUrlichs requested a review from itaysk May 2, 2023 07:37
itaysk
itaysk previously approved these changes May 2, 2023
Signed-off-by: AnaisUrlichs <urlichsanais@gmail.com>
@AnaisUrlichs AnaisUrlichs merged commit 30a01b9 into aquasecurity:master May 4, 2023
6 checks passed
AnaisUrlichs added a commit to AnaisUrlichs/tfsec that referenced this pull request May 15, 2023
* callout added to index docs

* adding tfsec to Trivy migration guide

* updating trivy to tfsec guide based on feedback

Signed-off-by: AnaisUrlichs <urlichsanais@gmail.com>

* updating trivy to tfsec guide based on feedback

Signed-off-by: AnaisUrlichs <urlichsanais@gmail.com>

* fix: changes to faq in migration guide

Signed-off-by: AnaisUrlichs <urlichsanais@gmail.com>

* changes to migration guide based on PR feedback

Signed-off-by: AnaisUrlichs <urlichsanais@gmail.com>

* updating link

Signed-off-by: AnaisUrlichs <urlichsanais@gmail.com>

---------

Signed-off-by: AnaisUrlichs <urlichsanais@gmail.com>
@knqyf263
Copy link
Contributor

This change is not deployed to the document. Then, people don't notice the migration announcement. I found a blog pointing out that. We should cut v1.28.2 or v1.29.0 so that the document will be up-to-date.
@simar7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants