The check for ignoring should use the resource block #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamg
reviewed
Jun 11, 2021
| @@ -111,6 +111,14 @@ func (scanner *Scanner) checkRangeIgnored(id string, r block.Range, b block.Rang | |||
| } | |||
|
|
|||
| // check the line above the block | |||
| if r.StartLine-1 > 0 { | |||
There was a problem hiding this comment.
It looks like this block already exists below 🤔
liamg
previously approved these changes
Jun 11, 2021
- take the range details from the resource block rather than the result block - add a check for someone adding the tfsec ignore in about the result block
owenrumney
force-pushed
the
owen-tidy-ignore-check
branch
from
2c745fa
to
fcd8948
Compare
|
Yup @liamg - that seems to have been unnecessary after all. The key part is the range filename |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
take the range details from the resource block rather than the result
block
add a check for someone adding the tfsec ignore in about the result
block
Resolves #781