Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make integration tests more robust #2681

Closed
geyslan opened this issue Feb 6, 2023 · 3 comments · Fixed by #2688
Closed

make integration tests more robust #2681

geyslan opened this issue Feb 6, 2023 · 3 comments · Fixed by #2688
Assignees
Milestone

Comments

@geyslan
Copy link
Member

geyslan commented Feb 6, 2023

Description

  • We only have a few tests for multi-scope. Since it touches many layers, we need to create a robust test suite.
  • Integration tests lack support for testing more event filter types. Building a more specialized test suite is a must.
@geyslan geyslan added this to the v0.12.0 milestone Feb 6, 2023
@geyslan geyslan self-assigned this Feb 6, 2023
@geyslan geyslan changed the title Create multi-scope test suite make integration tests more robust Feb 14, 2023
@geyslan geyslan modified the milestones: v0.12.0, v0.13.0 Feb 22, 2023
@geyslan geyslan modified the milestones: v0.13.0, v0.14.0 Mar 6, 2023
@rafaeldtinoco
Copy link
Contributor

For the integration tests, please be aware of: #1681 (comment) when adding tests that rely in PID=1. Cheers!

@geyslan
Copy link
Member Author

geyslan commented Apr 6, 2023

For the integration tests, please be aware of: #1681 (comment) when adding tests that rely in PID=1. Cheers!

OK. But if we run the integration test in a container just to not touch the host pid 1, that process will be a shell (for example)... so I think running tests just to filter the pid 1 that way doesn't make sense. It's the same of test against pid=whatever.

@rafaeldtinoco
Copy link
Contributor

so I think running tests just to filter the pid 1 that way doesn't make sense. It's the same of test against pid=whatever.

Sorry, I did not make myself clear, I just wanted to bring awareness to the issue, not to run tests inside a container as a suggestion!

@rafaeldtinoco rafaeldtinoco modified the milestones: v0.14.0, v0.15.0 May 3, 2023
@yanivagman yanivagman modified the milestones: v0.15.0, v0.16.0 Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants