Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add list-all-pkgs option #88

Merged
merged 2 commits into from
Dec 16, 2021
Merged

feat: Add list-all-pkgs option #88

merged 2 commits into from
Dec 16, 2021

Conversation

m-mizutani
Copy link
Contributor

Add list-all-pkgs option for #86

  • Add list-all-pkgs usage to README
  • Add list-all-pkgs option to action.yaml and entrypoint.sh

@CLAassistant
Copy link

CLAassistant commented Dec 11, 2021

CLA assistant check
All committers have signed the CLA.

entrypoint.sh Outdated
@@ -115,6 +118,10 @@ fi
if [ "$hideProgress" == "true" ];then
ARGS="$ARGS --no-progress"
fi

if [ "$listAllPkgs" == " true" ];then
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: white space is required before true because entrypoint.sh receives option as "-r true", not -r true. An argument of "-r true" option will be true (with whitespace prefix). Then this code works.

See an example of testing the action at 5th step "Run Trivy vulnerability scanner in repo mode"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can trim \r. Check examples in this file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simar7 Thank you for your comment. I fixed to trim whitespace at b642dfb

Copy link
Member

@simar7 simar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comment

@simar7 simar7 self-requested a review December 16, 2021 16:31
Copy link
Member

@simar7 simar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm thanks

@simar7 simar7 merged commit 8f4c716 into aquasecurity:master Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants