-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add list-all-pkgs option #88
feat: Add list-all-pkgs option #88
Conversation
entrypoint.sh
Outdated
@@ -115,6 +118,10 @@ fi | |||
if [ "$hideProgress" == "true" ];then | |||
ARGS="$ARGS --no-progress" | |||
fi | |||
|
|||
if [ "$listAllPkgs" == " true" ];then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE: white space is required before true
because entrypoint.sh receives option as "-r true"
, not -r true
. An argument of "-r true"
option will be true
(with whitespace prefix). Then this code works.
See an example of testing the action at 5th step "Run Trivy vulnerability scanner in repo mode"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can trim \r. Check examples in this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm thanks
Add list-all-pkgs option for #86
list-all-pkgs
option to action.yaml and entrypoint.sh