Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to update serviceMonitorSelectorNilUsesHelm values when using OpenShift Prometheus Operators is used #1330

Open
chen-keinan opened this issue Jun 27, 2023 Discussed in #1329 · 8 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. target/kubernetes Issues relating to kubernetes cluster scanning

Comments

@chen-keinan
Copy link
Contributor

Discussed in #1329

Originally posted by ajay15283 June 27, 2023
If prometheus is not installed from kube-prometheus-stack and instead openshift promethus operators were used in that case how to update serviceMonitorSelectorNilUsesHelmValues to false as the metrics are not visible in grafana dashboard


From Documentation
Our Prometheus installation needs to be slightly customised to discover ServiceMonitors by default. Create a values.yaml file with the following configuration:

prometheus:
prometheusSpec:
serviceMonitorSelectorNilUsesHelmValues: true
serviceMonitorSelector: {}
serviceMonitorNamespaceSelector: {}

@chen-keinan chen-keinan added kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. target/kubernetes Issues relating to kubernetes cluster scanning labels Jun 27, 2023
@chen-keinan
Copy link
Contributor Author

@ajay15283 the requirements sound reasonable , feel free to pick it up

@geoffrey1330
Copy link
Contributor

Hi @chen-keinan Could you please assign this issue to me.

@geoffrey1330
Copy link
Contributor

@ajay15283 if am to get you right. you want the installation process for prometheus in the docs to highlight the configurations when using either kube-prometheus-stack or openshift promethus operators?

@ajay15283
Copy link

@geoffrey1330 , yes the document is clear if the prometheus is installed from kube-prometheus-stack and have no specific information for prometheus installed from other options especially if its installed as an operator

@geoffrey1330
Copy link
Contributor

Alright

@geoffrey1330
Copy link
Contributor

Hi @ajay15283 it seems like the process of installing prometheus via prometheus-operator is no longer supported
as stated here
they suggested everyone should make use of the prometheus-community/kube-prometheus-stack as it has been moved there

@geoffrey1330
Copy link
Contributor

could you please move to the supported approach and close the issue.

@Prakashckesavan
Copy link

Did we got some solution to add serviceMonitorSelectorNilUsesHelmValues in openshift prometheus operator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. target/kubernetes Issues relating to kubernetes cluster scanning
Projects
None yet
Development

No branches or pull requests

4 participants