feat: Add support fo legacy dockercfg in scan jobs #1183
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now pods
imagePullSecrets
with secret typekubernetes.io/dockercfg
are ignored when generatingimagePullSecrets
for scan jobs. This PR adds functionality to treat legacykubernetes.io/dockercfg
secrets and converts them to newer version (kubernetes.io/dockerconfigjson
) for operator scan jobs.I think it's not too bad to support the old types of secrets since both types (
kubernetes.io/dockerconfigjson
andkubernetes.io/dockercfg
) perform the same function and are still supported by kubernetes.If you don't think so - could you please explain why we can't support both types of secrets in the operator?
Checklist