Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support fo legacy dockercfg in scan jobs #1183

Merged
merged 1 commit into from
Apr 27, 2023
Merged

feat: Add support fo legacy dockercfg in scan jobs #1183

merged 1 commit into from
Apr 27, 2023

Conversation

alex123012
Copy link
Contributor

@alex123012 alex123012 commented Apr 24, 2023

Description

Now pods imagePullSecrets with secret type kubernetes.io/dockercfg are ignored when generating imagePullSecrets for scan jobs. This PR adds functionality to treat legacy kubernetes.io/dockercfg secrets and converts them to newer version (kubernetes.io/dockerconfigjson) for operator scan jobs.

I think it's not too bad to support the old types of secrets since both types (kubernetes.io/dockerconfigjson and kubernetes.io/dockercfg) perform the same function and are still supported by kubernetes.
If you don't think so - could you please explain why we can't support both types of secrets in the operator?

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

Signed-off-by: alexey.makhonin <alexey.makhonin@flant.com>
@chen-keinan
Copy link
Collaborator

@alex123012 I'm cutting a patch release and I'll review your PR afterwards

@chen-keinan
Copy link
Collaborator

@alex123012 thank you for the contribution lgtm 🚀 , holding merge until trivy-operator v0.13.2 officially released

@chen-keinan chen-keinan merged commit 773f8e3 into aquasecurity:main Apr 27, 2023
6 checks passed
@alex123012 alex123012 deleted the use-legacy-dockercfg branch April 27, 2023 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants