Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Helm, allow to define service type for metrics Service #1929

Merged
merged 1 commit into from Mar 21, 2024

Conversation

ilpianista
Copy link
Contributor

Description

My use case is to scrape the metrics from a prometheus outside the Kubernetes cluster, thus I use a Service of kind NodePort for this.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@ilpianista ilpianista changed the title Allow to define service type for metrics Service helm: allow to define service type for metrics Service Mar 20, 2024
@ilpianista ilpianista changed the title helm: allow to define service type for metrics Service feat: Helm, allow to define service type for metrics Service Mar 20, 2024
@chen-keinan
Copy link
Collaborator

@ilpianista to overcome lint issues run mage generate:all and mage generate:docs

@ilpianista
Copy link
Contributor Author

@ilpianista to overcome lint issues run mage generate:all and mage generate:docs

Done, thanks!

Copy link
Collaborator

@chen-keinan chen-keinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ilpianista lgtm 🚀 thanks for the contribution

@chen-keinan chen-keinan merged commit 2432d4a into aquasecurity:main Mar 21, 2024
9 checks passed
@ilpianista ilpianista deleted the feature/service-type branch March 21, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants