Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add existing secret to policies bundle #1952

Merged
merged 2 commits into from Mar 27, 2024
Merged

feat: Add existing secret to policies bundle #1952

merged 2 commits into from Mar 27, 2024

Conversation

KevinDW-Fluxys
Copy link
Contributor

@KevinDW-Fluxys KevinDW-Fluxys commented Mar 27, 2024 •
edited

Description

Add the possibility to specify an existing secret for the policiesBundle secret.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@CLAassistant
Copy link

CLAassistant commented Mar 27, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@chen-keinan chen-keinan changed the title Add existingsecret to policiesbundle Add existing secret to policies bundle Mar 27, 2024
@chen-keinan chen-keinan changed the title Add existing secret to policies bundle feat: Add existing secret to policies bundle Mar 27, 2024
chen-keinan
chen-keinan approved these changes Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@chen-keinan chen-keinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KevinDW-Fluxys lgtm 🚀 thanks for the contributions

@chen-keinan chen-keinan merged commit 380f5d3 into aquasecurity:main Mar 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chen-keinan chen-keinan chen-keinan approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to add existing secret to policiesbundle in helmchart
3 participants
@KevinDW-Fluxys @CLAassistant @chen-keinan