feat: add flag to disable secret scan #227
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jose Donizetti jdbjunior@gmail.com
Description
I chose a design for this feature that I would prefer to refactor later, mostly because of #415. Configurations to enable/disable scanner are considered
operatorConfig
, and are done through env variables, which are not passed in the context of the scanning plugin. Scanning configurations are configured as a ConfigMap, consideredtrivyOperatorConfig
, and passed as context to the plugin. Because of this separation I'm setting the options fromoperatorConfig
intotrivyOperatorConfig
. Preferably I think we should only have one source of configuration, ConfigMap for all options related to the operator, which would be passed in the plugin context.Note, I'm not talking about the specific scanner configmap (trivy-operator-trivy-config) which is yet another configuration file, specific only for the trivy plugin.
Related issues
Remove this section if you don't have related PRs.
Checklist