-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ability to specify which Kubernetes workload resources to scan #523
Merged
chen-keinan
merged 20 commits into
aquasecurity:main
from
tks98:workload-scan-configuration
Sep 21, 2022
Merged
feat: add ability to specify which Kubernetes workload resources to scan #523
chen-keinan
merged 20 commits into
aquasecurity:main
from
tks98:workload-scan-configuration
Sep 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tks98
changed the title
Add ability to specify which Kubernetes workload resources to scan
feat: add ability to specify which Kubernetes workload resources to scan
Sep 16, 2022
chen-keinan
requested changes
Sep 18, 2022
@tks98 Look's good 🚀 thank you for the contribution , I have added couple of comments |
chen-keinan
requested changes
Sep 19, 2022
chen-keinan
approved these changes
Sep 21, 2022
This was referenced Oct 12, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the "targetWorkloads" config field which lets users specify the Kubernetes workload resources they want to scan using the vulnerability-report and config-audit report scanners. By default, all workload resource types are scanned.
PR adds logic to do this, adds a test case for the config, updates the usage documentation, updates the helm chart and static manifests.
I had a use-case similar to the related issue and made these modifications for personal use. I saw the related issue today and wanted to open this PR in case it could also benefit the wider community.
Please let me know if anything else is required, or needs to be changed. Thanks!
Related issues
Checklist