Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vulnerability class to the report #565

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

fardin01
Copy link
Contributor

@fardin01 fardin01 commented Oct 7, 2022

Description

This commit adds the vulnerability class (os-pkgs or lang-pkgs) to the report so that it becomes possible to identify vulnerabilities based on this.

Related issues

Fixes #564

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@CLAassistant
Copy link

CLAassistant commented Oct 7, 2022

CLA assistant check
All committers have signed the CLA.

@fardin01 fardin01 force-pushed the layer-type branch 2 times, most recently from 7f2232e to 60f0be0 Compare October 7, 2022 12:37
@chen-keinan
Copy link
Collaborator

chen-keinan commented Oct 11, 2022

@fardin01 thank you for the contribution ,this could be a nice addition.
in last release we have introduced a new capabilities for adding new fields to vulnerability report #468 , it will be great if you could extend it in the same way to introduce the class field , so we could have better control

@chen-keinan
Copy link
Collaborator

@fardin01 if you wish to discuss it in details I'll be happy. you can find me on Slack

@fardin01
Copy link
Contributor Author

@chen-keinan Thanks for your feedback, it's certainly better this way. Please take another look. Once you're okay with the changes I will update the docs too.

@chen-keinan
Copy link
Collaborator

chen-keinan commented Oct 15, 2022

@fardin01 look's good , could you please:

This commit adds the vulnarability class (`os-pkgs` or `lang-pkgs`) to the report so that it becomes possible to identify vulnarabilies based on this.

Fixes aquasecurity#564
@chen-keinan
Copy link
Collaborator

@fardin01 LGTM 🚀 thanks you for the contribution , I'm cutting a release today , I'll merge the code after the release.

@chen-keinan chen-keinan merged commit 2a440e3 into aquasecurity:main Oct 19, 2022
@fardin01 fardin01 deleted the layer-type branch October 19, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include the scanned layer in the report
3 participants