feat: increase the priority of imagePullSecret from the pod spec #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@verdel LGTM 🚀 could you please sign the CLA |
chen-keinan
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Then the values of the domains for docker registry in the pod imagePullSecret and service account imagePullSecret are the same, then in the final structure, the credentials from the secret specified in the Service Account will "overwrite" the values from the secret specified in the Pod specification.
I increase priority of the imagePullSecret from Pod priority. This coincides with the principle of how kubelet working with imagePullSecret.
Related issues