Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trivy is not scanning standalone java / nodejs / PHP binaries #1064

Closed
laurentdelosieresmano opened this issue Jun 14, 2021 · 5 comments · May be fixed by aquasecurity/go-dep-parser#35
Closed
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. triage/needs-information Indicates an issue needs more information in order to work on it.

Comments

@laurentdelosieresmano
Copy link

Hello AquaSecurity Team,

Trivy is not detecting / scanning standalone versions of java / nodejs / PHP / etc binaries. Is this something that you are planning to support ?

Best,
Laurent

@laurentdelosieresmano laurentdelosieresmano added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 14, 2021
@knqyf263 knqyf263 added the triage/needs-information Indicates an issue needs more information in order to work on it. label Jun 16, 2021
@knqyf263
Copy link
Collaborator

What is a Java binary? If you are talking about a Java archive, Trivy can detect it.
https://aquasecurity.github.io/trivy/v0.18.3/vuln-detection/library/

@laurentdelosieresmano
Copy link
Author

Hi knqyf263,

I was referring to java / PHP / node.js binaries that are shipped to the Docker images via tarballs and not OS packages. One example is openjdk:11.0.11-jre-buster which downloads and extracts the tarball [1]. Trivy is not scanning the "Java" binary issued from those tarballs. Same applies to nodejs / php / etc.

Let me know if this clarifies your doubt.

[1] github.com/AdoptOpenJDK/openjdk11-upstream-binaries/releases/download/jdk-11.0.11%2B9/OpenJDK11U-jre_x64_linux_11.0.11_9.tar.gz

Best,
Laurent

@github-actions
Copy link

This issue is stale because it has been labeled with inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Aug 16, 2021
@github-actions github-actions bot closed this as completed Sep 5, 2021
@kovacs-levent
Copy link

I think this is the same issue I faced while writing #6457.

After doing more research, I found that it seems like standalone binaries for PHP/Python interpreters (description is in the discussion, where I show an example case with a Python docker image) are not getting detected and put into the SBOMs generated. Is this something which is still not supported?

@kovacs-levent
Copy link

If anyone is actually interested in such feature outside of the maintainers of the project, feel free to use my fork:
https://github.com/kovacs-levent/trivy/tree/parse-binary-versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. triage/needs-information Indicates an issue needs more information in order to work on it.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants