Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic links support on config scan results #2837

Closed
chen-keinan opened this issue Sep 7, 2022 · 0 comments · Fixed by #2838
Closed

Dynamic links support on config scan results #2837

chen-keinan opened this issue Sep 7, 2022 · 0 comments · Fixed by #2838
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. target/kubernetes Issues relating to kubernetes cluster scanning

Comments

@chen-keinan
Copy link
Contributor

chen-keinan commented Sep 7, 2022 •
edited

it is require to support dynamic links when presenting results.
trivy has this logic to build the static PrimaryUrl , base on AVD url structure and AVDID.

This use case do not apply when the link is generated dynamically , meaning when rego policy metadata url is built based on input.
therefore it is suggested to build the primaryURL base on rego.Metadata.url if exist
Related #2785
@chen-keinan chen-keinan added kind/feature Categorizes issue or PR as related to a new feature. target/kubernetes Issues relating to kubernetes cluster scanning priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Sep 7, 2022
@chen-keinan chen-keinan mentioned this issue Sep 7, 2022
Merged
2 tasks
@chen-keinan chen-keinan mentioned this issue Sep 14, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. target/kubernetes Issues relating to kubernetes cluster scanning
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: dynamic links support for scan results chen-keinan/trivy
1 participant
@chen-keinan