Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AWS Account ID in secret rules #4492

Closed
knqyf263 opened this issue May 30, 2023 Discussed in #4491 · 1 comment · Fixed by #4494
Closed

Remove AWS Account ID in secret rules #4492

knqyf263 opened this issue May 30, 2023 Discussed in #4491 · 1 comment · Fixed by #4494
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/backlog Higher priority than priority/awaiting-more-evidence. scan/secret Issues relating to secret scanning
Milestone
v0.42.0

Comments

@knqyf263
Copy link
Collaborator

Discussed in #4491
@knqyf263 knqyf263 added priority/backlog Higher priority than priority/awaiting-more-evidence. scan/secret Issues relating to secret scanning labels May 30, 2023
@knqyf263 knqyf263 added this to the v0.42.0 milestone May 30, 2023
@knqyf263 knqyf263 added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels May 30, 2023
@knqyf263
Copy link
Collaborator Author

It is defined here

trivy/pkg/fanal/secret/builtin-rules.go

Lines 111 to 119 in 6fcd153

{
ID: "aws-account-id",
Category: CategoryAWS,
Severity: "HIGH",
Title: "AWS Account ID",
Regex: MustCompile(fmt.Sprintf(`(?i)%s%s%saccount_?(id)?%s%s%s(?P<secret>[0-9]{4}\-?[0-9]{4}\-?[0-9]{4})%s%s`, startSecret, quote, aws, quote, connect, quote, quote, endSecret)),
SecretGroupName: "secret",
Keywords: []string{"account"},
},

@DmitriyLewen DmitriyLewen mentioned this issue May 30, 2023
Merged
6 tasks
@knqyf263 knqyf263 removed this from the v0.42.0 milestone May 31, 2023
@knqyf263 knqyf263 added this to the v0.42.0 milestone May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/backlog Higher priority than priority/awaiting-more-evidence. scan/secret Issues relating to secret scanning
Projects
Trivy Roadmap
Archived in project
Milestone
v0.42.0
Development

Successfully merging a pull request may close this issue.

fix(secret): remove aws-account-id rule DmitriyLewen/trivy
2 participants
@knqyf263 @DmitriyLewen