Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(secret): detect AWS secrets in image config #5920

Closed
DmitriyLewen opened this issue Jan 11, 2024 Discussed in #5909 · 0 comments · Fixed by #5921
Closed

bug(secret): detect AWS secrets in image config #5920

DmitriyLewen opened this issue Jan 11, 2024 Discussed in #5909 · 0 comments · Fixed by #5921
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. scan/secret Issues relating to secret scanning

Comments

@DmitriyLewen
Copy link
Contributor

Description

To avoid false positives when a random string contains part of an AWS secret, we look for a space character at the end of the secret.
But there are cases when there may be , after secret.
e.g. in image config (json format):

  {
  "created": "2023-11-30T23:11:03Z",
  "created_by": "ENV AWS_SECRET_ACCESS_KEY=wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY",
  "comment": "buildkit.dockerfile.v0",
  "empty_layer": true
  },

Discussed in #5909

@DmitriyLewen DmitriyLewen added kind/bug Categorizes issue or PR as related to a bug. scan/secret Issues relating to secret scanning labels Jan 11, 2024
@DmitriyLewen DmitriyLewen self-assigned this Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. scan/secret Issues relating to secret scanning
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant