Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(swift): empty version of package #6167

Closed
DmitriyLewen opened this issue Feb 20, 2024 Discussed in #6165 · 0 comments · Fixed by #6168
Closed

bug(swift): empty version of package #6167

DmitriyLewen opened this issue Feb 20, 2024 Discussed in #6165 · 0 comments · Fixed by #6168
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@DmitriyLewen
Copy link
Contributor

Description

There are cases when Version field of Pin is empty.
In this case Branch field is used.
e.g.:

    {
          "identity" : "swift-ogg",
          "kind" : "remoteSourceControl",
          "location" : "https://github.com/element-hq/swift-ogg",
          "state" : {
            "branch" : "0.0.1",
            "revision" : "e9a9e7601da662fd8b97d93781ff5c60b4becf88"
          }
    }

We need to check Branch field or skip this package (with log message) if Version and Branch are empty.

Discussed in #6165

@DmitriyLewen DmitriyLewen added the kind/bug Categorizes issue or PR as related to a bug. label Feb 20, 2024
@DmitriyLewen DmitriyLewen self-assigned this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant