Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nodejs): add support for parsing workspaces from package.json as an object #6231

Merged
merged 8 commits into from Mar 27, 2024
Merged

fix(nodejs): add support for parsing workspaces from package.json as an object #6231

merged 8 commits into from Mar 27, 2024

Conversation

DmitriyLewen
Copy link
Contributor

Description

Add support for parsing workspaces from package.json as an object.
See more in #6129

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this Feb 29, 2024
@DmitriyLewen DmitriyLewen marked this pull request as ready for review February 29, 2024 09:33
@DmitriyLewen @knqyf263
refactor: update comment
cfefd35 
Co-authored-by: Teppei Fukuda <knqyf263@gmail.com>
@knqyf263
Copy link
Collaborator

@DmitriyLewen It's conflicting now.

@DmitriyLewen
Copy link
Contributor Author

Thanks! Resolved in 5c1894c

@knqyf263 knqyf263 added this pull request to the merge queue Mar 27, 2024
Merged via the queue into aquasecurity:main with commit f85c9fa Mar 27, 2024
12 checks passed
@DmitriyLewen DmitriyLewen deleted the fix-nodejs/package-json-workspaces-as-object branch March 27, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knqyf263 knqyf263 knqyf263 approved these changes

Assignees

@DmitriyLewen DmitriyLewen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(nodejs): package.json parser fails on object notation for workspaces
2 participants
@DmitriyLewen @knqyf263