Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(helm): scan the subcharts once #6382

Merged
merged 1 commit into from Mar 26, 2024
Merged

fix(helm): scan the subcharts once #6382

merged 1 commit into from Mar 26, 2024

Conversation

nikpivkin
Copy link
Contributor

@nikpivkin nikpivkin commented Mar 25, 2024 •
edited

Description

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@nikpivkin nikpivkin marked this pull request as ready for review March 25, 2024 10:08
@nikpivkin nikpivkin requested a review from simar7 as a code owner March 25, 2024 10:08
simar7
simar7 reviewed Mar 26, 2024
View reviewed changes
pkg/iac/scanners/helm/scanner.go
@@ -150,6 +157,7 @@ func (s *Scanner) ScanFS(ctx context.Context, target fs.FS, path string) (scan.R
} else {
results = append(results, scanResults...)
}
return fs.SkipDir
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my understanding: could you explain why we return early here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We recursively traverse the directories looking for a Chart. If we detect a Chart by the Chart.yaml file, we must stop traversing that directory, as that Chart is further processed by the parser, otherwise Subcharts will be rescanned.

@simar7 simar7 added this pull request to the merge queue Mar 26, 2024
Merged via the queue into aquasecurity:main with commit f148eb1 Mar 26, 2024
15 checks passed
@nikpivkin nikpivkin deleted the helm-subcharts branch March 28, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simar7 simar7 simar7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm child chart templates don't render with overrides from parent
2 participants
@nikpivkin @simar7