Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(misconf): Fallback to embedded check if needed #6505

Closed
simar7 opened this issue Apr 16, 2024 · 0 comments · Fixed by #6502
Closed

feat(misconf): Fallback to embedded check if needed #6505

simar7 opened this issue Apr 16, 2024 · 0 comments · Fixed by #6502
Assignees
Milestone

Comments

@simar7
Copy link
Member

simar7 commented Apr 16, 2024

Today if the checks bundle is corrupt, we fallback to the checks that are embedded within Trivy.

This also comes in handy if we ever release a bundle with a check that is either syntactically incorrect or simply fails to load within the OPA engine for any reason. In this case today we skip this check and continue with the rest.

We can extend this idea further by falling back to the embedded implementation of this check, rather than skipping it altogether. This would allow us to fallback to a version which we guarantee runs with the version of Trivy being used.

It would also help us in cases where we release a new version of a check based on a new schema.

@simar7 simar7 added this to the v0.51.0 milestone Apr 16, 2024
@simar7 simar7 self-assigned this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant