Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Golang version parsing from binaries w/GOEXPERIMENT #6696

Merged
merged 4 commits into from
May 16, 2024
Merged

fix: Golang version parsing from binaries w/GOEXPERIMENT #6696

merged 4 commits into from
May 16, 2024
+21 −1

Conversation

lyoung-confluent
Copy link
Contributor

@lyoung-confluent lyoung-confluent commented May 15, 2024 •
edited by knqyf263

Description

Fixes a bug when extracting the stdlib version from a Golang binary that was compiled with GOEXPERIMENT.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

knqyf263
knqyf263 approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@knqyf263 knqyf263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@knqyf263 knqyf263 enabled auto-merge May 16, 2024 04:36
@knqyf263 knqyf263 added this pull request to the merge queue May 16, 2024
Merged via the queue into aquasecurity:main with commit 696f2ae May 16, 2024
13 checks passed
@lyoung-confluent lyoung-confluent deleted the patch-1 branch May 16, 2024 06:27
knqyf263 pushed a commit that referenced this pull request May 20, 2024
@lyoung-confluent @knqyf263
fix: Golang version parsing from binaries w/GOEXPERIMENT (#6696)
d465d9d
@aqua-bot aqua-bot mentioned this pull request May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knqyf263 knqyf263 knqyf263 approved these changes

@DmitriyLewen DmitriyLewen Awaiting requested review from DmitriyLewen DmitriyLewen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

golang binary version parsing fails if GOEXPERIMENT was enabled
2 participants
@lyoung-confluent @knqyf263