Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(misconf): add metadata to Cloud schema #6831

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

nikpivkin
Copy link
Contributor

@nikpivkin nikpivkin commented May 31, 2024

Description

The schema was missing a metadata type.

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@nikpivkin nikpivkin marked this pull request as ready for review May 31, 2024 13:51
@nikpivkin nikpivkin requested a review from simar7 as a code owner May 31, 2024 13:51
@simar7
Copy link
Member

simar7 commented Jun 4, 2024

The change seems fine to me but what if a user tried to use new checks (downloaded a new bundle) that reference this schema but didn't have this schema (was using older version of trivy with old schema)? Would we still be able to fallback to the embedded version?

@nikpivkin
Copy link
Contributor Author

If Trivy still contains built-in checks that do not reference the new schema, then yes, they will be used.

@simar7 simar7 added this pull request to the merge queue Jun 5, 2024
Merged via the queue into aquasecurity:main with commit 02d5404 Jun 5, 2024
15 checks passed
@aqua-bot aqua-bot mentioned this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants