Disable Conda from UI and remove Conda install option #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsreekanti
reviewed
Nov 14, 2022
| @@ -351,11 +351,14 @@ export const SupportedIntegrations: ServiceInfoMap = { | |||
| activated: true, | |||
| category: 'data', | |||
| }, | |||
| // TODO: enable this once we release conda | |||
| /* | |||
| ['Conda']: { | |||
| logo: 'https://aqueduct-public-assets-bucket.s3.us-east-2.amazonaws.com/webapp/pages/integrations/conda.png', | |||
| activated: true, | |||
There was a problem hiding this comment.
@cw75, can't we just set activated to false here?
There was a problem hiding this comment.
If we set it to false, I think the UI will still show the Conda box but in a greyed-out state. If we're ok with this we can do that.
There was a problem hiding this comment.
Perhaps we can try to add a hidden flag in the future, but that would effectively do the same thing here.
agiron123
approved these changes
Nov 14, 2022
cw75
added
the
skip_integration_test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and why you are making these changes
We will re-enable the Conda integration option once we finish the backend implementation.
The Conda install option needs to be removed anyway. This should have been done in the previous PR but we forgot to remove it.
Related issue number (if any)
Loom demo (if any)
Checklist before requesting a review
python3 scripts/run_linters.py -hfor usage).run_integration_test: Runs integration testsskip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)