Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot have empty whitelist AND blacklist #228

Open
rafaeldamasceno opened this issue Dec 23, 2022 · 4 comments
Open

Cannot have empty whitelist AND blacklist #228

rafaeldamasceno opened this issue Dec 23, 2022 · 4 comments
Labels
💬 discussion Further information is requested 🔧 improvement General improvements to existing features

Comments

@rafaeldamasceno
Copy link
Contributor

rafaeldamasceno commented Dec 23, 2022

📝 Description

If you try to have empty whitelist AND blacklist at the same time to allow all sources, the bot fills the whitelist with youtube.com, effectively only allowing YouTube as a source.

🪜 Reproduction Steps

  1. Run /managesources and leave both lists empty.
  2. Run /play with a non YouTube source
  3. The "source not allowed" message is printed

ℹ Environment / Computer Info

  • Parrot version: 1.5.0
  • Operating System: Official Docker image

📸 Screenshots

No response

@rafaeldamasceno rafaeldamasceno added the 👓 triage This issue is being reviewed label Dec 23, 2022
@StaticRocket
Copy link
Contributor

There's an undocumented trick for this. Add "." As an entry to the blacklist.

@rafaeldamasceno
Copy link
Contributor Author

Yeah, I do this. Anything goes for the blacklist entry and the whitelist stays empty, but it's not immediate nor intuitive 😄

@aquelemiguel
Copy link
Owner

@rafaeldamasceno Thank you for the report. Yes, this is sort of an oversight on #223. You can get around it (as you and @StaticRocket both said) but I'm still not entirely happy on how intuitive this command is. Do you (or anyone) have a proposal for a better implementation?

@aquelemiguel aquelemiguel added 💬 discussion Further information is requested 🔧 improvement General improvements to existing features and removed 👓 triage This issue is being reviewed labels Dec 23, 2022
mustafasegf added a commit to mustafasegf/parrot that referenced this issue Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💬 discussion Further information is requested 🔧 improvement General improvements to existing features
Projects
None yet
Development

No branches or pull requests

4 participants
@aquelemiguel @rafaeldamasceno @StaticRocket and others