Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

Extensions should be updated so that they work #164

Open
patrickocoffeyo opened this issue Aug 11, 2016 · 5 comments
Open

Extensions should be updated so that they work #164

patrickocoffeyo opened this issue Aug 11, 2016 · 5 comments
Assignees
Labels
Milestone

Comments

@patrickocoffeyo
Copy link
Member

patrickocoffeyo commented Aug 11, 2016

As of now, some extensions don't work correctly with the latest version of Aquifer and they do not support or use some of the new APIs that we have so graciously built, such as the run api and the env api. These extensions should be updated so that they take advantage of these latest greatest blazing new features, and so that they are compatible with the breaking API changes we have made in the 1.0.0 branch.

Basically, we need to make sure that these following extensions work:

@chasingmaxwell
Copy link
Member

aquifer-git seems to be working without issue on its 1.0.0 branch, which is not the default branch so maybe that's why it seemed not to be working.

@chasingmaxwell
Copy link
Member

Changed the default branch of aquifer-git to 1.0.0 to match the aquifer project.

@generalredneck
Copy link
Contributor

I did run into a small snag... when we run aquifer extension-add aquifer-git it downloads the default version of ^0.3.0 which was the latest stable package. This may mean we need to add some documentation to tell users that they have to go in and change .aquifer/package.json to be the correct version of the extension that matches with this version. That's at least until 1.0.0 is released as stable for both aquifer and aquifer-git. Not sure if this should be an issue on aquifer-git or a general documentation thing we need to address in the wiki.

@JeffTomlinson
Copy link
Contributor

aquifer-coder fixes and enhancements here: aquifer/aquifer-coder#6

@chasingmaxwell
Copy link
Member

@generalredneck

This may mean we need to add some documentation to tell users that they have to go in and change .aquifer/package.json to be the correct version of the extension that matches with this version.

This should be set in the "source" property for the extension in aquifer.json. Ideally the user should never have to touch anything inside the .aquifer directory.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants