Skip to content
This repository has been archived by the owner on May 26, 2021. It is now read-only.

Updates and enhancements for 1.0.0 #6

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

Conversation

JeffTomlinson
Copy link

@JeffTomlinson JeffTomlinson commented Sep 13, 2016

See this issue for the Aquifer 1.0.0 release milestone.

To test:

  • Load up this branch in your Aquifer project.
  • Create a test directory in modules/custom
  • Add a test.module and a test.js file to the module and populate both with code containing code standards errors for that language.
  • Run aquifer lint and ensure your errors are caught.
  • See the README for new config override format and options and test them to ensure they work as expected.
  • Run aquifer lint -t modules/custom/test/test.js
    • Verify only the js file is linted
  • Run aquifer lint -t modules/custom/test/test.module
    • Verify only the module file is linted

@generalredneck generalredneck self-assigned this Sep 21, 2016
@chasingmaxwell chasingmaxwell self-assigned this Sep 30, 2016
@chasingmaxwell
Copy link
Member

@JeffTomlinson this was the output of running gulp lint in the aquifer-coder project itself.

[15:14:10] Using gulpfile ~/workspace/aquifer-coder/gulpfile.js
[15:14:10] Starting 'lint'...
[15:14:10] 
aquifer-coder.js
  109:10  error  Parsing error: Use of future reserved word in strict mode

✖ 1 problem (1 error, 0 warnings)

[15:14:10] Finished 'lint' after 248 ms

@chasingmaxwell
Copy link
Member

@JeffTomlinson other than the linting error above, this seems good to go.

@JeffTomlinson
Copy link
Author

Marking needs work as @patrickocoffeyo expressed interest in supporting globbing on the target path.

@generalredneck generalredneck removed their assignment Feb 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants