Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle custom react-scripts implementations #103

Closed
with-heart opened this issue Jun 26, 2019 · 1 comment
Closed

Handle custom react-scripts implementations #103

with-heart opened this issue Jun 26, 2019 · 1 comment
Labels
🏗️ enhancement New feature or request
Milestone
1.0

Comments

@with-heart
Copy link
Collaborator

with-heart commented Jun 26, 2019 •
edited
Loading

Discovered as part of #71

Since react-app-rewired supports custom scripts versions, we should too.

Currently, addLessLoader can break custom react-scripts implementations because it uses the path react-scripts/config/paths to load paths, but this may not be the location for custom packages. We need a mechanism to provide a custom paths value to addLessLoader.
@with-heart with-heart mentioned this issue Jun 26, 2019
Closed
@with-heart with-heart added 🐛 bug Something isn't working 🏗️ enhancement New feature or request :octocat: good first issue Good for newcomers and removed 🐛 bug Something isn't working labels Jun 26, 2019
@with-heart with-heart added this to the 1.0 milestone Jul 4, 2019
@with-heart
Copy link
Collaborator Author

More information about react-app-rewired custom react-scripts requirements and structure here: https://github.com/timarney/react-app-rewired#2-custom-scripts-versions

@with-heart with-heart mentioned this issue Aug 22, 2019
Closed
@with-heart with-heart removed the :octocat: good first issue Good for newcomers label Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🏗️ enhancement New feature or request
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@with-heart