Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(addLessLoader): can set less-loader option #255

Open
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

xyy94813
Copy link

@xyy94813 xyy94813 commented Jun 6, 2020

support set less loader option
fix valid problem when use newest css loader

Break Change: change the usage of addLessLoader

support set less-loader option
add unit test about `addLessLoader`

NOTE: change the way to set loader option
@xyy94813
Copy link
Author

xyy94813 commented Jun 6, 2020

fix issue #242 #253 #241
support PR #243

@xyy94813
Copy link
Author

xyy94813 commented Jun 6, 2020

@Anish-Agnihotri

Do you have time to code review???

@xyy94813
Copy link
Author

xyy94813 commented Jun 6, 2020

also PR #220

@Anish-Agnihotri
Copy link
Collaborator

Yes, will take a look at these today.

@xyy94813
Copy link
Author

@Anish-Agnihotri Is there any problem in this PR???

@Anish-Agnihotri
Copy link
Collaborator

Hey, super sorry I didn’t get around to this—slipped off my plate. I’ll get back to you in <24hrs. I had done a quick review and it looked good, so will likely be merged soon.

@xyy94813
Copy link
Author

If someone need this PR:
Try to use https://github.com/xyy94813/customize-cra-less-loader

@ShellWen
Copy link

@Anish-Agnihotri merge soon, plz

@avinmaster
Copy link

Please merge!

@HSQCoollaughing
Copy link

Hey, super sorry I didn’t get around to this—slipped off my plate. I’ll get back to you in <24hrs. I had done a quick review and it looked good, so will likely be merged soon.

2023!!!! ? so will likely be merged soon

@Maxhu787
Copy link

mergeeeeeeeeeeeeee

@avinmaster
Copy link

MERGE!)

@amitthk
Copy link

amitthk commented Mar 14, 2024

Merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants