Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Counselor authentication #77

Merged
merged 19 commits into from
Apr 13, 2020
Merged

Counselor authentication #77

merged 19 commits into from
Apr 13, 2020

Conversation

arades79
Copy link
Owner

Summary

This PR finally authenticates counselors signing in!

This also finishes one CLI mechanism for adding counselors.

In this version, hyperdome_server generate will generate a one-time-use code that can be given to a counselor. This code is placed in the "password" field when adding a server.
The client will authenticate using ed448 keys. Currently the counselor's keys are encrypted, but with a static hard-coded password.

Server settings are now stored and reloaded with the application.

This PR fixes #38 and invalidates #13 by cementing key authentication, and never broadcasting a password.

Checklist

  • If code changes were made then they have been tested.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@arades79 arades79 added bug Something isn't working enhancement New feature or request labels Apr 13, 2020
@arades79 arades79 linked an issue Apr 13, 2020 that may be closed by this pull request
store and send passwords in a secure way #13
Closed
stevenpitts
stevenpitts approved these changes Apr 13, 2020
View reviewed changes
Copy link
Collaborator

@stevenpitts stevenpitts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

hyperdome/client/add_server_dialog.py Show resolved Hide resolved
hyperdome/client/main.py Show resolved Hide resolved
hyperdome/common/common.py Show resolved Hide resolved
hyperdome/common/common.py Show resolved Hide resolved
hyperdome/common/common.py Show resolved Hide resolved
hyperdome/common/types.py Show resolved Hide resolved
@arades79 arades79 merged commit 5cbe9dd into develop Apr 13, 2020
@arades79 arades79 mentioned this pull request Apr 13, 2020
Closed
@arades79 arades79 added this to the 0.2 release milestone Apr 15, 2020
@arades79 arades79 deleted the counselor_authentication branch November 3, 2020 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenpitts stevenpitts stevenpitts approved these changes

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
0.2 release
Development

Successfully merging this pull request may close these issues.

Add administrative abilities to server CLI store and send passwords in a secure way
2 participants
@arades79 @stevenpitts