Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links and pyglet version #15

Merged
merged 4 commits into from
Oct 22, 2022
Merged

Fix links and pyglet version #15

merged 4 commits into from
Oct 22, 2022

Conversation

dan-pandori
Copy link
Contributor

  • Redirected ppo2 to ppo, since the former seems not to exist in that docs page.
  • Redirect to the gymlibrary docs for CartPole, since the old link failed.
  • Added pyglet==1.4 to the list of required packages to install, since one of the later cells needs this.

Tested by running all cells from the following Google colab link:
https://colab.research.google.com/github/dan-pandori/rl-tutorial-jnrr19/blob/linkfix/1_getting_started.ipynb

And verifying that the edited links went to reasonable locations.

Copy link
Owner

@araffin araffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fixes =)

@araffin araffin changed the title Linkfix Fix link and pyglet version Oct 22, 2022
@araffin araffin changed the title Fix link and pyglet version Fix links and pyglet version Oct 22, 2022
@araffin araffin merged commit baca7e5 into araffin:sb3 Oct 22, 2022
@dan-pandori
Copy link
Contributor Author

Thanks for setting up the tutorial! It's been very helpful

@dan-pandori dan-pandori deleted the linkfix branch October 22, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants