Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: gracefully handle cases where content URIs are invalid #26

Merged
merged 1 commit into from Aug 17, 2018
Merged

fix: gracefully handle cases where content URIs are invalid #26

merged 1 commit into from Aug 17, 2018

Commits on Aug 17, 2018

  1. fix: gracefully handle cases where content URIs are invalid 

    Prior to this commit, all content URIs of application versions are
expected to follow the format `<provider>:<identifier>`. In case a
content URI doesn't follow this format, an error is thrown.

We now ensure that in such cases, the code still executes but resolves
early with an error or warning respectively.

It also fixes aragon#27 where parsing content URIs that contain more than
one split character (e.g. `:` in `http://localhost:8080/foo/bar`) splits
the `identifier` as well (which we don't want).

Fixes aragon#20, aragon#27
    @0x-r4bbit
    0x-r4bbit committed Aug 17, 2018
    Configuration menu
    Copy the full SHA
    d53212f View commit details
    Browse the repository at this point in the history