Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Vault: ETH native support and arbitrary connectors for managing different token standards #129

Merged
merged 39 commits into from Mar 20, 2018

Conversation

Projects
None yet
3 participants
@izqui
Copy link
Member

izqui commented Mar 14, 2018

Closes #125
Closes aragon/aragonOS#163
Closes #44

API broke a little bit so Finance app is updated too, also will remove WETH support in Finance

  • Adapt Finance app #135
  • Adapt beta, dev and demo templates #140
  • Migrate to aOS ^3.1 (edit: updated to v3.1.1)
  • Deploy update templates to rinkeby and create update in APM repo
  • Publish new @aragon/apps-vault 2.0.0

@izqui izqui requested a review from bingen Mar 15, 2018

@izqui izqui removed the needs tests label Mar 15, 2018

bingen and others added some commits Mar 16, 2018

finance: Adapt to new Vault (#135)
* finance: Adapt to new Vault

* finance: Adapt to new Vault (address PR comments)

* finance: Adapt to new Vault (address PR comments)
@coveralls

This comment has been minimized.

Copy link

coveralls commented Mar 16, 2018

Coverage Status

Coverage decreased (-12.3%) to 83.849% when pulling 42c954d on good-vault into e2d6001 on master.

bingen and others added some commits Mar 16, 2018

vault: fix coverage and tests
Coverage complains about files with only interfaces.
IConnector had been renamed to IVaultConnecto.
Now creating a new Vault instance creates connectors and initializes.
finance: fix tests
Now creating a new Vault instance creates connectors and initializes.
Wrong token approval (probably due to merge conflict, as this was
changed recently).
tmp
vault: Remove redundant variables
They are already in VaultBase

@izqui izqui merged commit 42c954d into master Mar 20, 2018

2 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
coverage/coveralls Coverage increased (+1.5%) to 83.849%
Details
license/cla Contributor License Agreement is signed.
Details

@izqui izqui changed the title [WIP] New Vault: ETH native support and arbitrary connectors for managing different token standards New Vault: ETH native support and arbitrary connectors for managing different token standards Mar 20, 2018

@sohkai sohkai deleted the good-vault branch Mar 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.