Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Vault: ETH native support and arbitrary connectors for managing different token standards #129

Merged
merged 39 commits into from
Mar 20, 2018
Merged

New Vault: ETH native support and arbitrary connectors for managing different token standards #129

merged 39 commits into from
Mar 20, 2018

Conversation

izqui
Copy link
Contributor

@izqui izqui commented Mar 14, 2018 •
edited
Loading

Closes #125
Closes aragon/aragonOS#163
Closes #44

API broke a little bit so Finance app is updated too, also will remove WETH support in Finance

@izqui izqui requested a review from bingen March 15, 2018 21:47
@izqui izqui mentioned this pull request Mar 16, 2018
Merged
@coveralls
Copy link

coveralls commented Mar 16, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-12.3%) to 83.849% when pulling 42c954d on good-vault into e2d6001 on master.

ßingen and others added 11 commits March 16, 2018 23:30
Fix lint errors
6117167
vault: fix coverage and tests
b787a5d 
Coverage complains about files with only interfaces.
IConnector had been renamed to IVaultConnecto.
Now creating a new Vault instance creates connectors and initializes.
finance: fix tests
4cf0a69 
Now creating a new Vault instance creates connectors and initializes.
Wrong token approval (probably due to merge conflict, as this was
changed recently).
tmp
db70f08
@izqui
Remove abis file
ef13ad5
vault: Fix lint warnings
e450209
vault: Remove redundant variables
869ad3a 
They are already in VaultBase
vault: Remove constructor, refactor initialize
c503098
templates: Remove EtherToken from tests
dfb3ad7
[wip] vault: Try to increase coverage
d8dac5a
@izqui
Merge branch 'beta_test_remove_ethertoken' of github.com:aragon/arago…
42c954d 
…n-apps into good-vault
@izqui izqui merged commit 42c954d into master Mar 20, 2018
@izqui izqui changed the title [WIP] New Vault: ETH native support and arbitrary connectors for managing different token standards New Vault: ETH native support and arbitrary connectors for managing different token standards Mar 20, 2018
@sohkai sohkai deleted the good-vault branch March 28, 2018 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bingen bingen Awaiting requested review from bingen

Assignees
No one assigned
Labels
app: vault breaking-change component: contract
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@izqui @coveralls @bingen