Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voting: display the balance at the time the vote was created #449

Closed
wants to merge 1 commit into from

Conversation

bpierre
Copy link
Contributor

@bpierre bpierre commented Sep 15, 2018

No description provided.

@bpierre bpierre requested a review from izqui September 15, 2018 18:00
@bpierre bpierre changed the title Display the balance at the time the vote was created Voting: display the balance at the time the vote was created Sep 15, 2018
@bpierre bpierre added this to the sprint: 1.2 milestone Sep 15, 2018
@bpierre bpierre mentioned this pull request Sep 15, 2018
7 tasks
@sohkai
Copy link
Contributor

sohkai commented Sep 16, 2018

@bpierre Did you have a look at #342? I think we don't need the balance part of the ABI entirely since the voting app generally uses balanceOfAt() for any calculations or token balances.

@bpierre
Copy link
Contributor Author

bpierre commented Sep 17, 2018

@sohkai oops I missed that, I’m closing this 👍

@bpierre bpierre closed this Sep 17, 2018
@sohkai sohkai deleted the voting-fix-balance branch September 17, 2018 13:22
bpierre added a commit that referenced this pull request Sep 21, 2018
- Upgrade eslint.
- Move to parcel (from react-scripts).
- Move to react-spring (from react-motion).
- Card layout (issue: aragon/design#10).
- Display the user vote (“Your vote” badge) and the block number on the cards.
- Display the correct balance (PR: #449).
- Execute a vote (issue: #216 (comment), PR: #450).
- Explicitly change a vote (PR: #450).
- Fix the bars transitions.
- Update Aragon UI (fix the flickering when opening the sidebar on Chrome).
ramilexe pushed a commit to ConsiderItDone/aragon-apps that referenced this pull request Dec 9, 2021
- Upgrade eslint.
- Move to parcel (from react-scripts).
- Move to react-spring (from react-motion).
- Card layout (issue: aragon/design#10).
- Display the user vote (“Your vote” badge) and the block number on the cards.
- Display the correct balance (PR: aragon#449).
- Execute a vote (issue: aragon#216 (comment), PR: aragon#450).
- Explicitly change a vote (PR: aragon#450).
- Fix the bars transitions.
- Update Aragon UI (fix the flickering when opening the sidebar on Chrome).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants