Apps: update for @aragon/rpc-messenger's new deferred behaviour #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
sohkai
changed the title
2color
added a commit
that referenced
this pull request
May 29, 2019
…t-api * token-manager-loading-state: Upgrade @aragon/ui to 0.40.1 Apps: update for @aragon/rpc-messenger's new deferred behaviour (#871) Use a boolean for loading indicator Token Manager: update @aragon/api dependencies Token Manager: fix lint Token Manager: only use the SyncIndicator for the loading states (#873) Token Manager: fix loading indicator not being shown when syncing Upgrade aragon ui Handle custom events before contract events Remove unneeded import Update apps/token-manager/app/src/script.js Travis: optimizations and refactor to use build stages (#865) Update Travis CI badge (#866) Hoist common dependencies (#863) Reduce sync status in background script Add syncing states (faked for now)
MickdeGraaf
pushed a commit
to MickdeGraaf/aragon-apps
that referenced
this pull request
Jan 28, 2020
ramilexe
pushed a commit
to ConsiderItDone/aragon-apps
that referenced
this pull request
Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change from aragon/aragon.js#305 (to be released as
@aragon/rpc-messenger@2).I believe intents were the only RPC requests we were sending without caring for their response. All other requests were either made for their response, or we wanted to have feedback if the user cancelled (e.g. identity modifications)