Payroll: Move payroll example kit into contracts/examples/ dir
#898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sohkai
reviewed
Jul 3, 2019
| @@ -2,7 +2,6 @@ module.exports = { | |||
| norpc: true, | |||
| copyPackages: ['@aragon/os', '@aragon/apps-finance', '@aragon/apps-vault', '@aragon/test-helpers'], | |||
| skipFiles: [ | |||
| 'PayrollKit.sol', | |||
There was a problem hiding this comment.
Should we add examples/ to this skip list?
There was a problem hiding this comment.
sure, forgot to update this one 😅
sohkai
approved these changes
Jul 3, 2019
There was a problem hiding this comment.
We should also double check if https://github.com/aragon/aragon-apps/blob/master/future-apps/payroll/package.json#L27 still works (I think it does, assuming Truffle compiles it).
confirmed! 👌 |
ramilexe
pushed a commit
to ConsiderItDone/aragon-apps
that referenced
this pull request
Dec 9, 2021
…gon#898) * payroll: move payroll kit to `contracts/examples/` dir * payroll: ignore examples dir for coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply to avoid confusing with a real kit, it is only used for testing purposes