Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payroll: Move payroll example kit into `contracts/examples/` dir #898

Merged
merged 2 commits into from Jul 3, 2019

Conversation

Projects
None yet
3 participants
@facuspagnuolo
Copy link
Contributor

commented Jul 3, 2019

Simply to avoid confusing with a real kit, it is only used for testing purposes

@facuspagnuolo facuspagnuolo requested a review from sohkai Jul 3, 2019

@facuspagnuolo facuspagnuolo self-assigned this Jul 3, 2019

@@ -2,7 +2,6 @@ module.exports = {
norpc: true,
copyPackages: ['@aragon/os', '@aragon/apps-finance', '@aragon/apps-vault', '@aragon/test-helpers'],
skipFiles: [
'PayrollKit.sol',

This comment has been minimized.

Copy link
@sohkai

sohkai Jul 3, 2019

Member

Should we add examples/ to this skip list?

This comment has been minimized.

Copy link
@facuspagnuolo

facuspagnuolo Jul 3, 2019

Author Contributor

sure, forgot to update this one 😅

@sohkai

sohkai approved these changes Jul 3, 2019

Copy link
Member

left a comment

We should also double check if https://github.com/aragon/aragon-apps/blob/master/future-apps/payroll/package.json#L27 still works (I think it does, assuming Truffle compiles it).

@facuspagnuolo

This comment has been minimized.

Copy link
Contributor Author

commented Jul 3, 2019

We should also double check if https://github.com/aragon/aragon-apps/blob/master/future-apps/payroll/package.json#L27 still works (I think it does, assuming Truffle compiles it).

confirmed! 👌

@facuspagnuolo facuspagnuolo merged commit c9d9a8e into master Jul 3, 2019

6 checks passed

License Compliance Analysis timed out. Check FOSSA for updates.
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
coverage/coveralls First build on payroll/move_kit_to_examples at 97.732%
Details
license/cla Contributor License Agreement is signed.
Details

@facuspagnuolo facuspagnuolo deleted the payroll/move_kit_to_examples branch Jul 3, 2019

@coveralls

This comment has been minimized.

Copy link

commented Jul 3, 2019

Coverage Status

Coverage decreased (-0.009%) to 97.732% when pulling a31fe1e on payroll/move_kit_to_examples into b989638 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.