Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to fetch current version artifact.json instead of generating it when publishing only content #143

Closed
izqui opened this issue Jun 20, 2018 · 3 comments
Closed

Attempt to fetch current version artifact.json instead of generating it when publishing only content #143

izqui opened this issue Jun 20, 2018 · 3 comments
Assignees
@0xGabi
Labels
🚀 new feature A change that adds new functionality to the API 🙏 good first issue An easy issue for a new contributor

Comments

@izqui
Copy link
Contributor

izqui commented Jun 20, 2018

Instead of generating the artifact again for upgrades that don't change the smart contract code, the CLI should try to fetch the artifact for the current version instead of generating it and publish it.

The version in the artifact file has to be modified to the actual version being published.
@izqui izqui added 🚀 new feature A change that adds new functionality to the API 🙏 good first issue An easy issue for a new contributor epic: dev tooling labels Jun 20, 2018
@izqui izqui mentioned this issue Jun 20, 2018
Merged
@sohkai
Copy link
Contributor

sohkai commented Nov 18, 2018

@izqui I believe this is either fixed or unnecessary now?

@sohkai
Copy link
Contributor

sohkai commented May 18, 2019

@0x6431346e @0xGabi Could you double check if this is still an issue?

@0xGabi 0xGabi self-assigned this May 18, 2019
@0xGabi
Copy link
Contributor

0xGabi commented Jul 6, 2019

This was tested and fixed with #426

@0xGabi 0xGabi closed this as completed Jul 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xGabi 0xGabi

Labels
🚀 new feature A change that adds new functionality to the API 🙏 good first issue An easy issue for a new contributor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@izqui @sohkai @0xGabi