Token Manager Install Catch-22

[kernelwhisperer]

from @lkngtn:

If you setup a local RPC instance and wish to deploy a new token manager into a DAO there is a catch-22. The token manager cannot be initialized unless there is a deployed minime contract with the token manager’s address set as its controller and you cannot deploy the token manager (and get its address) without initializing. 🤷‍♂️

Allowing the user to deploy applications and then initialize them with a separate command would resolve this issue.

[Quazia]

An alternative to allowing users to deploy the application and initialize separately would be to provide a script option in the install command that would run some application-specific code inbetween the contract deploy and the application initialization.

[lkngtn]

initialize separately would be to provide a script option in the install command that would run some application-specific code inbetween the contract deploy and the application initialization.

I'm wondering what the advantage here would be as opposed to scripting the cli itself?

[Quazia]

Yeah, separating it out is a better idea. Daniel suggested we just modify the install command with an option that prevents initialization.

[kernelwhisperer]

Allowing the user to deploy applications and then initialize them with a separate command would resolve this issue.

Looks like this is already possible with the --app-init none flag.

Installing a TokenManager on rinkeby:

1. Create a minime token: dao token <name> <symbol> --environment aragon:rinkeby
2. Install the app without initializing:
   dao install <dao> token-manager --app-init none --environment aragon:rinkeby
   If you have the Manage apps permission it will get installed immediately:

 ℹ Successfully executed: "Create a new upgradeable instance of 0x9fa3927f639745e587912d4b0fea7ef9013bf93fb907d29faeab57417ba6e1d4 app linked to the Kernel, setting its code to 0x8C06aEBF29F20A2e09b32F5d44cEa49Db3EC2eE0 ."

otherwise, if it goes to a vote first, you need to find the proxy address by doing dao apps <dao> --all (the all flag lists permisionless apps) after the vote passes.

3. Change the token controller to the new app's proxy address with dao token change-controller.
4. Set some permissions to the new app to show up, otherwise aragon.js will not find it:

✖ No artifact found for 0x8C06aEBF29F20A2e09b32F5d44cEa49Db3EC2eE0

Example:

dao acl create <dao> <proxy-address> MINT_ROLE <entity> <manager>  --environment aragon:rinkeby

5. Initialize the app

dao exec <dao> <proxy-address> initialize <token-address> <transferable> <max-tokens-per-account>  --environment aragon:rinkeby

[sohkai]

🎉 this is great to see!

you need to find the proxy address by going on etherscan to your app's Kernel and look for the NewAppProxy event

Could this be highlighted with dao apps somehow (looking through etherscan would be pretty tedious)?

[kernelwhisperer]

Could this be highlighted with dao apps somehow (looking through etherscan would be pretty tedious)?

Exactly! I was thinking something like dao apps <dao> --no-permissions could do this 🤔 .

[kernelwhisperer]

Opened #340 to allow checking apps without permissions