Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start using shrinkwrap #477

Closed
kernelwhisperer opened this issue May 22, 2019 · 2 comments
Closed

Start using shrinkwrap #477

kernelwhisperer opened this issue May 22, 2019 · 2 comments
Labels
💬 needs discussion A feature not yet agreed on that needs more discussion
Projects
Aragon Mesh Team

Comments

@kernelwhisperer
Copy link
Contributor

💥 Proposal

I think we should consider using npm shrinkwrap.

Why

  • We encountered quite a few issues with dependencies: bugs in new releases, semver issues (people love using 0.x for major updates 🙄 ), etc.

  • We spend a lot of time debugging: figuring out how is npm deduping packages, why does it work on one machine and not another, etc.

  • The only (?) downside of using shrinkwrap is that people will not install the latest dependencies, but I don't see that as a problem. I think is better to wait a few weeks and then get a tested release.
@kernelwhisperer kernelwhisperer added the 💬 needs discussion A feature not yet agreed on that needs more discussion label May 22, 2019
@sohkai
Copy link
Contributor

sohkai commented May 22, 2019

From https://docs.npmjs.com/files/shrinkwrap.json:

The recommended use-case for npm-shrinkwrap.json is applications deployed through the publishing process on the registry: for example, daemons and command-line tools intended as global installs or devDependencies.

Sounds like exactly what we need 😄!

@kernelwhisperer kernelwhisperer added this to To do in Aragon Mesh Team via automation May 22, 2019
@sohkai sohkai mentioned this issue May 22, 2019
Merged
@kernelwhisperer kernelwhisperer mentioned this issue May 23, 2019
Merged
4 tasks
@0xGabi 0xGabi moved this from To do to In progress in Aragon Mesh Team May 28, 2019
@0xGabi
Copy link
Contributor

0xGabi commented May 28, 2019

Closed by #483

@0xGabi 0xGabi closed this as completed May 28, 2019
Aragon Mesh Team automation moved this from In progress to Done May 28, 2019
@0xGabi 0xGabi mentioned this issue Jun 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💬 needs discussion A feature not yet agreed on that needs more discussion
Projects
No open projects
Aragon Mesh Team
  
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sohkai @0xGabi @kernelwhisperer