Specify truffle config when executing CLI commands.

[willjgriff]

This issue was funded with 60 DAI, see more issues on our dao projects app.

🚀 Feature

Ability to specify the truffle config used when executing CLI commands.

Have you read the Contributing Guidelines on issues?

Yes

Motivation

We cannot currently run or deploy apps with a custom truffle configuration. A custom truffle configuration could specify Solidity compilation optimisation or developer defined gas prices for deployment.

The aragon app I'm building has a fairly large contract. It's large enough to require optimisation be run on it to enable deployment without an OOG error. I currently have to specify optimisation in my project truffle config and execute truffle compile --all right before either aragon run or aragon apm publish. This seems to work as truffle does not recompile the contracts if already compiled. I have already run into one situation where this doesn't work which required commenting out Solidity to continue, I imagine I could come across more situations in the future.

Secondly, if the network's gas prices demand higher than the default in truffle config (10 Gwei I believe) then there's a chance an app won't be deployed. Also if a developer wants to pay less than 10 Gwei to deploy their app when gas prices are cheap, I'm not sure how they can.

Pitch

I imagine an extra argument that can be passed to the relevant CLI commands, likely any of those that can currently specify the --environment argument, which allows the user to specify a truffle config to use. There may be an alternative approach such as specifying the truffle config in arapp.json although I can't say what would be most appropriate.

Edit: It seems I can specify gas prices for the networks used if specified in my project truffle config. However, I'm still unsure how to enable Solidity compilation optimisation.

[kernelwhisperer]

Edit: It seems I can specify gas prices for the networks used if specified in my project truffle config. However, I'm still unsure how to enable Solidity compilation optimisation.

Could you please post the truffle config you're using? (the one with the compilation optimisation)

[willjgriff]

I use Truffle v5+ which requires the following:

module.exports = {
    networks: {...},
    compilers: {
        solc: {
            version: "0.4.24",  
            settings: {             
                optimizer: {
                    enabled: true,
                    runs: 200
                }
            }
        }
    }
}

For Truffle version prior to v5 (v4 etc) it needs to be:

module.exports = {
    networks: {...},
    solc: {
        optimizer: {
            enabled: true,
            runs: 200
        }
    }
}

[sohkai]

The CLI should probably change the truffle config if it detects your project directory has a truffle.js or truffle-config.js. Not sure if truffle supports node resolution for its configs, but if it does we could also do the same.

I was wondering why this wasn't a problem for aragon-apps since we use our own truffle config and have enabled optimization but, of course, we don't use aragon run in them 😅