Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent drafts happening without a randomness seed #15

Closed
izqui opened this issue Mar 23, 2019 · 3 comments
Closed

Prevent drafts happening without a randomness seed #15

izqui opened this issue Mar 23, 2019 · 3 comments
Assignees
Milestone

Comments

@izqui
Copy link
Contributor

izqui commented Mar 23, 2019

Right now, if the first draft of a term happens more than 256 blocks after the term starts, the blockhash that will be returned for the randomnessBN of the term will be 0.

Options to work around this problem:

@bingen
Copy link
Contributor

bingen commented Mar 25, 2019

Some context: #6 (comment)

@bingen
Copy link
Contributor

bingen commented Jun 5, 2019

I think both options are complementary and that even if we implemented the second one we would still need the first one to make sure we have proper randomness.
Besides now we already are able to delay draft to later terms (#44), so I'm going to do the first one and we can still add the extra heartbeat function later.

bingen pushed a commit that referenced this issue Jun 5, 2019
Drafting will have to wait for a later term where randomness seed is
available.

Closes #15.
@facuspagnuolo
Copy link
Contributor

Closed by #58

@izqui izqui added this to the Freeze #1 milestone Oct 15, 2019
facuspagnuolo pushed a commit that referenced this issue Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants