Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Court: Explore encapsulating the initialization logic in separate contracts #78

Closed
facuspagnuolo opened this issue Aug 6, 2019 · 0 comments · Fixed by #151
Closed

Court: Explore encapsulating the initialization logic in separate contracts #78

facuspagnuolo opened this issue Aug 6, 2019 · 0 comments · Fixed by #151
Assignees
@facuspagnuolo
Labels
1st audit freeze component:contracts Contracts related requirements enhancement New enhancement request
Milestone
v1.0 freeze

Comments

@facuspagnuolo
Copy link
Contributor

Currently, all the initialization logic is triggered by the Court constructor.
Explore if we can make things clearer having all these logic in a separate contract (or more than one)
@facuspagnuolo facuspagnuolo added enhancement New enhancement request component:contracts Contracts related requirements labels Aug 6, 2019
@facuspagnuolo facuspagnuolo mentioned this issue Sep 5, 2019
Merged
@facuspagnuolo facuspagnuolo mentioned this issue Sep 17, 2019
Merged
@facuspagnuolo facuspagnuolo changed the title Explore encapsulating the initialization logic in separate contracts Court: Explore encapsulating the initialization logic in separate contracts Sep 19, 2019
@facuspagnuolo facuspagnuolo self-assigned this Sep 21, 2019
@facuspagnuolo facuspagnuolo mentioned this issue Sep 27, 2019
Closed
@facuspagnuolo facuspagnuolo mentioned this issue Oct 7, 2019
Merged
@bingen bingen added this to the v1.0 freeze milestone Oct 15, 2019
facuspagnuolo added a commit that referenced this issue Oct 12, 2020
@facuspagnuolo @sohkai
Subscriptions: Support app fees (#78)
31d5eaa 
* Avoid having duplicate modules

Governor can repeat `setModule` operation with the same address and
the tx will succeed. This would make the subgraph to have duplicated
modules, and some aggregated values would be incremented in excess.

* Adapt to new Subscriptions module

See #264.
Also, allow to have blacklisted modules, that won’t be loaded onto the
subgraph (so we can get rid of old modules).

* Update schema.png

* Apply suggestions from code review

Co-authored-by: Facu Spagnuolo <facuspagnuolo@users.noreply.github.com>

* Adapt to new Subscriptions module, fixes

Address comments from PR #73.

* subscriptions: support old claimed fees event

* Chore: Migrate blacklisted modules parsing script to node

* subscriptions: fix comments about contracts versions

* chore: migrate blacklisted modules to JS file

* chore: improve blacklisted modules parsing

* chore: add configuration markdown file

* Chore: Move configuration md to docs dir

* Blacklist: Improve parser script

Co-authored-by: Brett Sun <qisheng.brett.sun@gmail.com>

* subscriptions: fix modules case

* subscriptions: fix module creation

* subgraph: use to hex string always

* subscriptions: update manifest abi

* subscriptions: remove auto-generated blacklisted modules file

* subscriptions: update rinkeby blacklisted modules

* chore: rollback the graph cli version

* subscriptions: model fee movements

* subscriptions: store token to fee movements

* subscriptions: save subscription fee token as address

* subscriptions: save app ID as hex string for app fees

Co-authored-by: ßingen <bingen@aragon.one>
Co-authored-by: Brett Sun <qisheng.brett.sun@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@facuspagnuolo facuspagnuolo

Labels
1st audit freeze component:contracts Contracts related requirements enhancement New enhancement request
Projects
None yet
Milestone
v1.0 freeze
Development

Successfully merging a pull request may close this issue.

Core: Implement recoverability mechanism aragon/aragon-court
2 participants
@bingen @facuspagnuolo