Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bonding curve #69

Closed
wants to merge 2 commits into from
Closed

Bonding curve #69

wants to merge 2 commits into from

Conversation

bingen
Copy link
Contributor

@bingen bingen commented Jul 30, 2019

NOTICE: Change base to development once #64 has been merged.

Integrate bonding curve from Fundraising project

Just import it and add a simple test file to check that the whole flow works: buying into the curve and then staking and activating.

TODO:

  • Update all tests to Truffle 5

ßingen added 2 commits July 30, 2019 18:23
Court: Integrate bonding curve from Fundraising project
6787f81 
Just import it and add a simple test file to check that the whole flow
works: buying into the curve and then staking and activating.
Upgrade to Truffle 5
1022f39
@bingen bingen self-assigned this Jul 30, 2019
facuspagnuolo
facuspagnuolo reviewed Jul 31, 2019
View reviewed changes
Copy link
Contributor

@facuspagnuolo facuspagnuolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO if we are testing the bonding curve isolated doesn't make much sense, they should be doing that... if the court is interacting with it, we should have some tests for it
but looking at the tests I think you're using the bonding curve to get some ANJ only

@bingen
Copy link
Contributor Author

bingen commented Jul 31, 2019

IMO if we are testing the bonding curve isolated doesn't make much sense, they should be doing that...

Yes, I agree. There's already a good set of tests in fundraising repo.

but looking at the tests I think you're using the bonding curve to get some ANJ only

Yes that was the idea, and what we discussed offline. Besides a small sanity check here, the only thing being tested is that we can use Fundraising implementation as it is in order for jurors to convert ANT to Court stake through a bonding curve. This I think it makes total sense.
If the question is where to put this test, here or anywhere else, I don't mind. Let me know where you want it and I'll move it.

@facuspagnuolo facuspagnuolo added the component:tests Tests related requirements label Aug 7, 2019
@sohkai sohkai added this to the Sprint 26 milestone Aug 9, 2019
@facuspagnuolo facuspagnuolo deleted the bonding_curve branch September 19, 2019 20:14
@izqui izqui modified the milestones: Sprint 26, Freeze #1 Oct 15, 2019
facuspagnuolo pushed a commit that referenced this pull request Oct 12, 2020
Agreement: Simplify dispute metadata construction (#69)
3a740b6 
* agreement: Simplify dispute metadata construction

See: aragon/aragon-apps#1188

* fixup! agreement: Simplify dispute metadata construction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facuspagnuolo facuspagnuolo facuspagnuolo left review comments

@izqui izqui Awaiting requested review from izqui

Assignees

@bingen bingen

Labels
component:tests Tests related requirements
Projects
None yet
Milestone
v1.0 freeze
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bingen @facuspagnuolo @izqui @sohkai