Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a signer provider selector #2

Closed
onbjerg opened this issue Apr 5, 2018 · 7 comments
Closed

Add a signer provider selector #2

onbjerg opened this issue Apr 5, 2018 · 7 comments
Labels
enhancement New feature or request

Comments

@onbjerg
Copy link
Contributor

onbjerg commented Apr 5, 2018

Should be possible to choose what Web3 provider is injected in place of MetaMask:

  • Private key (should also note that this is insecure)
  • Ledger
  • OS signer (when that exists)
@onbjerg onbjerg added the enhancement New feature or request label Apr 5, 2018
@luisivan
Copy link
Contributor

luisivan commented Apr 5, 2018

Why not just resorting to the OS signer, which then can resort to private key/Ledger/etc?

@onbjerg
Copy link
Contributor Author

onbjerg commented Apr 5, 2018

Because it doesn't work yet, so this is a temporary measure :p

@luisivan
Copy link
Contributor

luisivan commented Apr 5, 2018

Oh, try the new version, it even works with Ledger:tm:

@onbjerg
Copy link
Contributor Author

onbjerg commented Apr 5, 2018

I know it works with Ledger, but it only runs Ganache. No way to switch to a remote node right now.

@luisivan
Copy link
Contributor

luisivan commented Apr 5, 2018

Gotcha. Should be trivial to implement though

@onbjerg
Copy link
Contributor Author

onbjerg commented Apr 5, 2018

Ya

@luisivan
Copy link
Contributor

luisivan commented Oct 8, 2018

Closing in favor of aragon/client#374

@luisivan luisivan closed this as completed Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants