Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrapper: emit an error if an app's manifest or artifact.json could not be loaded or parsed #163

Open
sohkai opened this issue Sep 26, 2018 · 0 comments
Open

Wrapper: emit an error if an app's manifest or artifact.json could not be loaded or parsed #163

sohkai opened this issue Sep 26, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@sohkai
Copy link
Contributor

sohkai commented Sep 26, 2018 •
edited
Loading

Right now aragon.js just swallows up failures to load or parse these files and tries to give back as much info as it can (just the on-chain info if both files failed to load).

Ideally, aragon.js would do this, but also capture the files that failed, or set a flag in the app instance, so that frontends can display an error state to the user.

Changes to apm.js are likely also needed...
@sohkai sohkai added the enhancement New feature or request label Sep 26, 2018
@sohkai sohkai changed the title [wrapper] Emit an error if an app's manifest or artifact.json could not be loaded [Wrapper] Emit an error if an app's manifest or artifact.json could not be loaded Jan 14, 2019
@sohkai sohkai changed the title [Wrapper] Emit an error if an app's manifest or artifact.json could not be loaded [Wrapper] Emit an error if an app's manifest or artifact.json could not be loaded or parsed Jan 14, 2019
@sohkai sohkai changed the title [Wrapper] Emit an error if an app's manifest or artifact.json could not be loaded or parsed Wrapper: emit an error if an app's manifest or artifact.json could not be loaded or parsed Jan 14, 2019
@stale stale bot added the abandoned label Jul 13, 2019
@sohkai sohkai removed the abandoned label Jul 13, 2019
@stale stale bot added the abandoned label Jan 9, 2020
@aragon aragon deleted a comment from stale bot Jan 11, 2020
@stale stale bot removed the abandoned label Jan 11, 2020
@aragon aragon deleted a comment from stale bot Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sohkai