Make the cache work in not-a-browser #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
Erhh, this needs a bit more work. I need to build a non-browser bundle as well (in #71) |
So, the primary issue with working in both the browser and outside the browser right now is to make sure that we do not require the filesystem specific adapters for lowdb in the browser, as that will break. Rather than spend a lot of time on fixing this right now (which I have already done), we're just going to use the memory adapter. This works fine for things like Aragon CLI, but will be a pain when we start using Electron, unless Electron also supports localStorage (which I think it does).
|
This works now (pivoted from original solution, pls give me feedback on this new short-term one) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, the primary issue with working in both the browser and outside the browser right now is to make sure that we do not require the filesystem specific adapters for lowdb in the browser, as that will break.
Rather than spend a lot of time on fixing this right now (which I have already done), we're just going to use the memory adapter.
This works fine for things like Aragon CLI, but will be a pain when we start using Electron, unless Electron also supports localStorage (which I think it does).
Closes #69