New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the cache work in not-a-browser #72

Merged
merged 4 commits into from Mar 15, 2018

Conversation

Projects
None yet
2 participants
@onbjerg
Contributor

onbjerg commented Mar 12, 2018

So, the primary issue with working in both the browser and outside the browser right now is to make sure that we do not require the filesystem specific adapters for lowdb in the browser, as that will break.

Rather than spend a lot of time on fixing this right now (which I have already done), we're just going to use the memory adapter.

This works fine for things like Aragon CLI, but will be a pain when we start using Electron, unless Electron also supports localStorage (which I think it does).

Closes #69

@onbjerg onbjerg referenced this pull request Mar 12, 2018

Merged

Implement beta templates #59

@onbjerg onbjerg added this to the aragon.js 2.0.0 milestone Mar 12, 2018

@onbjerg

This comment has been minimized.

Show comment
Hide comment
@onbjerg

onbjerg Mar 12, 2018

Contributor

Erhh, this needs a bit more work. I need to build a non-browser bundle as well (in #71)

Contributor

onbjerg commented Mar 12, 2018

Erhh, this needs a bit more work. I need to build a non-browser bundle as well (in #71)

onbjerg added some commits Mar 14, 2018

wrapper: Use memory cache adapter outside browser
So, the primary issue with working in both the browser
and outside the browser right now is to make sure that
we do not require the filesystem specific adapters for lowdb
in the browser, as that will break.

Rather than spend a lot of time on fixing this right now
(which I have already done), we're just going to use the
memory adapter.

This works fine for things like Aragon CLI, but will be a pain
when we start using Electron, unless Electron also supports
localStorage (which I think it does).

@onbjerg onbjerg requested review from izqui and sohkai Mar 14, 2018

@onbjerg

This comment has been minimized.

Show comment
Hide comment
@onbjerg

onbjerg Mar 14, 2018

Contributor

This works now (pivoted from original solution, pls give me feedback on this new short-term one)

Contributor

onbjerg commented Mar 14, 2018

This works now (pivoted from original solution, pls give me feedback on this new short-term one)

@sohkai

sohkai approved these changes Mar 15, 2018

Looks good!

@onbjerg onbjerg merged commit 0135442 into master Mar 15, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@onbjerg onbjerg deleted the browser-cache branch Mar 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment