Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Onboarding: setting support/quorum to 100% will make the template revert #1070

Closed
izqui opened this issue Sep 16, 2019 · 0 comments · Fixed by #1114
Closed

Onboarding: setting support/quorum to 100% will make the template revert #1070

izqui opened this issue Sep 16, 2019 · 0 comments · Fixed by #1114
Labels
bug

Comments

@izqui
Copy link
Contributor

izqui commented Sep 16, 2019 •
edited
Loading

Proposed solution: If any of these params are set to 100% in the UI, convert it to 10^18 - 1 (as >99.99...99% is effectively 100%) before sending the transaction to the template contract
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Onboarding: clamp value of Voting's support and quorum to their max values aragon/client
1 participant
@izqui