DAO-31 Govern DAO migration page #1585
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use use-wallet 0.9.0 * remove unnecessary dependency * fix the CI error @toruslabs/fetch-node-details@2.7.0 for node version too old * Re-order templates (#1558) * detect network change * use injected instead of provided connector, as provided connector is a hack to around web3.js overrides * switch welcome page content base on network * more reactive network changes * fix error on missing networkType * eth node and ipfs settings by network * getAppLocator by network type Co-authored-by: Rekard0 <5880388+Rekard0@users.noreply.github.com>
* temporary use --network-concurrency 1, to be removed once use-wallet 0.9.0 is published.
* connectors redesigned for multichain
* only show network settings on mainnet
* refactor and attempt to fix websocket leaks * fix connection error on socket disconnect web3 * eslint fixed * update aragon wrapper Co-authored-by: yuetloo <contact@yuetloo.com>
* connectors redesigned for multichain * eslint problems fixed * multi localstorage * update multi localstorage * update aragon.js wrapper * eslint fixed
* fix load org error on network switch * ipfs settings is network agnostic * code review comment * remove mainnet from network type
fix bug that caused create dao to freeze
* show network only for mainnet * replace logging with sentry with console.log * remove sentry * add newline * remove obsolete .env.enc file
* fix deployment error due to missing wallet * redirect to home on network change * fix lint error
DAO-31 Govern Subgraph − Implement dao / daos queries
Before implementing these entities, we should define more precisely what a DAO is in Govern, see @0xGabi’s comment. |
|
closing this PR as we have different implementation for this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@novaknole the page is created as per the ticket, but, I think we may need to change the design to follow the same design as Permission, i.e. use SidePanel and have the Govern address input field moved to the side panel, to take advantage of the framework detecting no wallet connection/creating vote etc..
https://github.com/aragon/client/blob/master/src/apps/Permissions/AssignPermissionPanel.js
https://github.com/aragon/client/blob/master/src/contexts/PermissionsContext.js#L76
Please take a look and let me know.