Fix an onboarding crash happening with specific web3 provider setups #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling getBalance(), it was possible to sometimes get another value than an big integer as a string. Having `null` as a result, and passing it to the BN.js constructor, could lead to an infinit loop [1]. To prevent this issue to happen again: - In the app, `balance` is now always represented by a BN.js instance. To represent an unknown balance, `new BN(-1)` is now used rather than `null`. - The result of getbalance() is now filtered to ensure that we are passing an integer to BN.js. Otherwise, we pass "-1". [1] indutny/bn.js#186
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #440
When calling getBalance(), it was possible to sometimes get another value than an big integer as a string.
Having
nullas a result, and passing it to the BN.js constructor, could lead to an infinite loop.To prevent this issue to happen again:
In the app,
balanceis now always represented by a BN.js instance. To represent an unknown balance,new BN(-1)is now used rather thannull.The result of getbalance() is now filtered to ensure that we are passing an integer to BN.js. Otherwise, we pass
"-1".